Create About Page for 7.1 - #12845
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @webVerts. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
rbcorrales
left a comment
There was a problem hiding this comment.
Tested locally at different breakpoints plus an he_IL RTL pass. All five pages render clean, no PHP notices, and the RTL headers resolve correctly.
Comments are mostly copy. The one worth catching before RC1 is the run-on on 141, since it's user visible. The rest is minor.
|
No, there's no need for a separate ticket; this ticket covers the entire scope of building out the About Page, because it's a one-off task for the release. |
|
@marko-srb Can you take a look at the color contrast concerns on mobile? We could use something like a text shadow on mobile only that addressed this, e.g. ( |
|
👋 Your suggestion works well. Let's go with minimal shadows. Not a good practice in general, but great fix suggestion for now. We will fix the images themselves so no contrast issues are present, prior 7.1 release. And swap them. Do we still need svg images for RTL? I thought we are going with webp? If we need them, I can deliver them in 1hr About page, text update is ok to happen, even if not applicable by someone on Google file. It's easy for us to change there, as long as it is good on the actual page. Though I'd leave this to Anne. But if this needs to ship, I can review, or provide text in an hr. Thank you! |
Co-authored-by: Ramon Corrales <rbcorrales@users.noreply.github.com>
Co-authored-by: Ramon Corrales <rbcorrales@users.noreply.github.com>
There was a problem hiding this comment.
Do we need to flip this image as well?
There was a problem hiding this comment.
Technically, the abstract 7.1 wouldn't make sense flipped, and @marko-srb adjusted the image so it would work either way. I don't have a strong opinion, and would prefer that somebody natively in an RTL language make that call...
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
|
This is updated to address feedback and add the URLs for images from the CDN, but I'm noting the the feature images aren't currently in the CDN, so I'm changing those back for tetsing. |

Initial draft of the About Page for WordPress 7.1
This draft adds the feature images locally, as the CDN copies are not yet available.
Trac ticket: https://core.trac.wordpress.org/ticket/65698
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.